Skip to content

SSH Keyfile location support for systemd launcher/cluster #863

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
johrstrom merged 4 commits into from
Feb 6, 2025
Merged

SSH Keyfile location support for systemd launcher/cluster #863

johrstrom merged 4 commits into from
Feb 6, 2025

Conversation

@adamboutcher
Copy link
Contributor

@adamboutcher adamboutcher commented Jan 28, 2025 •
edited
Loading

This should give some (albeit poor quality) support for alternative ssh keyfile locations using the systemd launcher.

Our use case is so users don't have to think about ssh key generation etc to reduce a barrier of entry.

I don't write ruby so this is probably a mess.

johrstrom
johrstrom reviewed Jan 28, 2025
View reviewed changes
@johrstrom
Copy link
Contributor

johrstrom commented Jan 28, 2025

We (OSC) use HostBasedAuthentication, but I'm OK with this addition either way. I just left a comment around insert maybe not being the best approach.

@adamboutcher
Update launcher.rb
1a4e729 
Hopefully make this "more ruby" like.
@adamboutcher
Update launcher.rb
ca43adf 
remove duplicate line.
@adamboutcher
Update launcher.rb
38fdec7 
removed duplicate end.

My poor copy & paste skills...
@johrstrom
Copy link
Contributor

johrstrom commented Feb 6, 2025

Sorry for the delay - I'm still working through test cases that should have caught that issue (if there was one?)

@johrstrom
Copy link
Contributor

johrstrom commented Feb 6, 2025

Sorry for the delay - I'm still working through test cases that should have caught that issue (if there was one?)

🤦‍♂️ I added a test for the linux_host adapter, not the systemd adapter.

I'll get this merged shortly and add some tests for the same.

@johrstrom johrstrom requested review from johrstrom and removed request for johrstrom February 6, 2025 17:44
johrstrom
johrstrom approved these changes Feb 6, 2025
View reviewed changes
Copy link
Contributor

@johrstrom johrstrom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working through this with me!

@johrstrom johrstrom merged commit db13933 into OSC:master Feb 6, 2025
4 checks passed
This was referenced Feb 6, 2025
Closed
Merged
@adamboutcher
Copy link
Contributor Author

adamboutcher commented Feb 8, 2025

Thanks for working through this with me!

No worries, I'm not well versed in git or ruby so I can only apologise for being slow and cumbersome.

@johrstrom
Copy link
Contributor

johrstrom commented Feb 10, 2025

No worries, I'm not well versed in git or ruby so I can only apologise for being slow and cumbersome.

No issues at all. I'm happy to get a contribution in any form. Thanks again!

@adamboutcher adamboutcher deleted the systemd_sshkey branch March 6, 2025 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@johrstrom johrstrom johrstrom approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@adamboutcher @johrstrom